test: realign project-layout asset guard with current README - #106
Merged
Conversation
The docs overhaul in #100 dropped the hero render and the stale-branded GitLab MR screenshots from the README, but the layout guard still required those exact image references — so main CI has been red since #100 (the only failing assertion was the README hero reference; several more in the same block were latently false). Rewrite the asset block to assert only the assets the README currently links to (avatar preview, examples doc, bot avatar), each checked both for on-disk presence and for an actual README reference. This keeps the broken-link guard meaningful without pinning files the docs no longer use.
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Main CI has been red since #100. The docs overhaul dropped the hero render and the stale-branded GitLab MR screenshots from the README, but
tests/test_project_layout.pystill required those exact image references. pytest stops at the first failed assertion (the README hero reference), which masked that several sibling assertions in the same block were also latently false (both GitLab MR screenshots and the demo gif are no longer in the README either).What
Rewrite the asset block in
test_project_tree_keeps_config_but_not_runtime_checkoutsto assert only the assets the README currently links to — the bot avatar preview, the examples doc, and the bot avatar — each checked both for on-disk presence and for an actual README reference. This keeps the broken-link guard meaningful without pinning files the docs no longer use.Verification
uv run pytest -q→ 416 passed, 10 deselected (was 415 passed + 1 failed).uv run ruff check tests/→ clean.Notes / follow-ups (not in this PR)
docs/images/bubo-hero.png,docs/images/gitlab-mr-review-*.png,docs/media/bubo-demo.gif) are now orphaned on disk — referenced nowhere. They can be deleted as a separate cleanup; the hero + screenshots carried old branding in-pixel, which is why fix(docs): owl intro, feature tables, MCP page; drop stale-branded images #100 dropped them.