Skip to content

Add Textract OP #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bingmeiyou wants to merge 17 commits into
base: feature-vpto-backend
Choose a base branch
from
Open

Add Textract OP #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
09ca031
feat(textract): add textract_template.py + 42 lit tests
May 29, 2026
92d94b7
feat(textract): add ST test infrastructure (M2L/M2R, FP, V2V)
May 29, 2026
467fc44
fix(textract): add transpose support for mat2left/mat2right and const…
Jun 1, 2026
021c8f2
Merge 9 FP dtype pair lit files into single all_dtypes.pto
Jun 1, 2026
97883a5
fix(textract_v2v): use tload/tstore instead of mte_gm_ub/mte_ub_gm
Jun 1, 2026
8582b5a
fix(textract_v2v): add addr operand for level3 alloc_tile
Jun 1, 2026
b0dabe9
fix(textract ST): use aclFinalize instead of aclrtFinalize
Jun 1, 2026
d1e961d
fix(textract_fp): use same-fractal layout for right_tile to avoid tra…
Jun 1, 2026
6e166cc
fix(textract_fp): restore cross-fractal layout and fix golden to use B^T
Jun 1, 2026
88e3db9
fix(textract_fp): negate golden to match actual computation
Jun 2, 2026
8e19ed7
fix(textract_fp): use matmul(A, B) for golden (kernel computes A×B no…
Jun 2, 2026
4230604
fix(textract_fp): use matmul(A, B.T) for golden to match transpose=tr…
Jun 2, 2026
d681c4f
fix(textract_fp): fix L1 memory address overlap causing rows 8-15 cor…
Jun 2, 2026
3bf0f14
fix(textract): pass index_row/index_col to mte_l1_l0a/l0b start_row/s…
Jun 4, 2026
8da0838
fix: correct PR386 license header in textract files
Jun 4, 2026
7847a48
fix(textract): remove C++ verifier check for non-zero offsets
Jun 4, 2026
1e1d0e2
docs(textract): clarify Vec→Vec uses vlds/vsts by design, not DMA
Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions lib/PTO/IR/PTO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5166,15 +5166,8 @@ mlir::LogicalResult mlir::pto::TExtractOp::verify() {
return emitOpError("expects A5 textract src to use a supported mat blayout/slayout combination");
if (*dstSpace == pto::AddressSpace::LEFT ||
*dstSpace == pto::AddressSpace::RIGHT) {
auto indexRowVal = getConstantIntegerValueEx(
getIndexRow(), /*includeIndexAndIntOpsInConstFold=*/true);
auto indexColVal = getConstantIntegerValueEx(
getIndexCol(), /*includeIndexAndIntOpsInConstFold=*/true);
if (!indexRowVal || !indexColVal || *indexRowVal != 0 ||
*indexColVal != 0)
return emitOpError(
"expects A5 mat->left/right textract to have indexRow=0 and "
"indexCol=0 (offset extraction not yet supported)");
// Non-zero indexRow/indexCol is supported via start_row/start_col
// on mte_l1_l0a/l0b (PR #469).
}
if (*dstSpace == pto::AddressSpace::LEFT) {
if (dstTb.getBLayoutValueI32() != static_cast<int32_t>(pto::BLayout::ColMajor) ||
Expand Down
Loading
Loading