Skip to content

Handle exceptions in created tasks #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
torarvid wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle exceptions in created tasks #163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69efad5
Handle exceptions in created tasks
torarvid Feb 9, 2023
fffa397
Don't raise exception in task_done when cancelled
torarvid Feb 20, 2023
566fddd
Remove closure
mosquito Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions aiormq/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,18 @@ def __init__(self, loop: asyncio.AbstractEventLoop):
def __on_task_done(
self, future: Union[asyncio.Future, TaskWrapper],
) -> Callable[..., Any]:
def remover(*_: Any) -> None:
nonlocal future
if future in self.futures:
self.futures.remove(future)
if future in self.futures:
self.futures.remove(future)

return remover
if not isinstance(future, TaskWrapper):
return

with suppress(asyncio.CancelledError):
future.result()

def add(self, future: Union[asyncio.Future, TaskWrapper]) -> None:
self.futures.add(future)
future.add_done_callback(self.__on_task_done(future))
future.add_done_callback(self.__on_task_done)

if self.parent:
self.parent.add(future)
Expand Down