Workaround for overflow error mentioned in issue #20 - #23
Open
leetaiyi wants to merge 4 commits into
Open
Conversation
Added a workaround for large intersections of df and gr_bam by splitting both into subsets based on how many more factors of 2 the product of the subset of (chr,strand) was over 2^31. Will be missing a few cases in the splits but is a reasonable workaround for now. Included a hardcoding for nb_cpus=8
Added missing numpy import
Because Pyranges documented it was available but never implemented it >:(
Cleaned the `n$m` format to just output `n`. This is a very space-inefficient workaround, but do not know the pyranges class well enough to find a better way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If detected that the product of the sizes of df and gr_bam are over 2^31, will subset them both to avoid the overflow error. Will cause in a few lost edgecases near where the divisions are though. Now works on the cases where it failed due to this error.