Repository navigation
test: repair remaining bulk-merge regression fixtures - #6375
Conversation
Restore typecheck after #3826 called uniqueBy, and align the red fixtures with the merged pcap, browser, IDA, and Hopper contracts. Co-authored-by: morluto <morluto@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Low impact] The PR appears safe to merge; the remaining changes repair tests without changing production behavior. SummaryRepairs the remaining fixtures and assertions across five test files. No production code changes.
The PR is partly superseded by Reviews (2) · Last reviewed commit: "chore: reconcile bulk-merge regression r..." · Reviewed by Greptile |
Main at 7091be2 fixes the uniqueBy compile error and the browser, IDA, and pcap fixture failures that were failing this PR's merge checkout. Co-authored-by: morluto <morluto@users.noreply.github.com>
Summary
Current main already contains the reconstruction deduplication repair, packet-client identity fixture update, most storage fixture repair, and corrected Linux installer call signatures from this PR. After merging main
357100242, the remaining diff covers five test files:/etc/os-releasereads.This PR is partially superseded by #4642, but the CLI fixture repair and remaining test improvements are still needed. The resolved diff changes no production code or provider behavior.
Validation
On Node 24.18.0,
npm run test:focused --the browser diff, pcap service, two Linux Hopper, two reconstruction candidates, IDA session, and public browser CLI test files passed: 8 files, 192 tests.npm run check:fastpassed typecheck and lint. The public CLI regression for reordered current-version storage passed.Hosted checks on the updated head are pending. No real browser, tshark, IDA or Hopper installation was exercised locally. Legacy hashed storage remains incomparable.
Author readiness
Human owner: @morluto
Before merge
type(scope): outcome.No related issue: the failures were observed on the #6363 and #6368 merge CI runs after the bulk squash-merge. No user-visible CLI or MCP contract change, so that box stays open.