Skip to content

test: repair remaining bulk-merge regression fixtures - #6375

Merged
morluto merged 2 commits into
mainfrom
cursor/repair-main-after-bulk-merge-782d
Oct 22, 2026
Merged

morluto merged 2 commits into
mainfrom
cursor/repair-main-after-bulk-merge-782d

Conversation

@morluto

@morluto morluto commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Current main already contains the reconstruction deduplication repair, packet-client identity fixture update, most storage fixture repair, and corrected Linux installer call signatures from this PR. After merging main 357100242, the remaining diff covers five test files:

  • Give the public CLI storage-comparison fixture the current fingerprint version so it exercises order-independent comparison rather than legacy-fingerprint withholding. Use the owning version constant in both CLI and domain fixtures.
  • Assert IDA regex deadline failures through structured operation, CPU resource and reported deadline fields. Preserve main's exact recovered search-row assertion; diagnostic prose stays covered by the matcher tests.
  • Supply deterministic unavailable-distribution readers in Linux installer tests that do not classify a host, avoiding ambient /etc/os-release reads.

This PR is partially superseded by #4642, but the CLI fixture repair and remaining test improvements are still needed. The resolved diff changes no production code or provider behavior.

Validation

On Node 24.18.0, npm run test:focused -- the browser diff, pcap service, two Linux Hopper, two reconstruction candidates, IDA session, and public browser CLI test files passed: 8 files, 192 tests. npm run check:fast passed typecheck and lint. The public CLI regression for reordered current-version storage passed.

Hosted checks on the updated head are pending. No real browser, tshark, IDA or Hopper installation was exercised locally. Legacy hashed storage remains incomparable.

Author readiness

Human owner: @morluto

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

No related issue: the failures were observed on the #6363 and #6368 merge CI runs after the bulk squash-merge. No user-visible CLI or MCP contract change, so that box stays open.

Restore typecheck after #3826 called uniqueBy, and align the red fixtures
with the merged pcap, browser, IDA, and Hopper contracts.

Co-authored-by: morluto <morluto@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T19:22:31.826465Z 255e930 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; the remaining changes repair tests without changing production behavior.

Summary

Repairs the remaining fixtures and assertions across five test files. No production code changes.

  • Browser storage comparisons use the current fingerprint version.
  • IDA deadline tests check the structured CPU error details.
  • Linux installer tests use an unavailable distribution fixture.

The PR is partly superseded by main, but not fully: the base still lacks the CLI fixture’s fingerprint version. No actionable correctness, security, or repository-rule issues were found. Tests were not run during this review.

Reviews (2) · Last reviewed commit: "chore: reconcile bulk-merge regression r..." · Reviewed by Greptile

@morluto morluto changed the title fix: repair main after bulk merge test: repair remaining bulk-merge regression fixtures Oct 22, 2026
@morluto
morluto merged commit 7091be2 into main Oct 22, 2026
3 of 5 checks passed
@morluto
morluto deleted the cursor/repair-main-after-bulk-merge-782d branch October 22, 2026 19:21
cursor Bot pushed a commit that referenced this pull request Oct 22, 2026
Main at 7091be2 fixes the uniqueBy compile error and the
browser, IDA, and pcap fixture failures that were failing this
PR's merge checkout.

Co-authored-by: morluto <morluto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants