Skip to content

NO-ISSUE: feat(skills): register review-with-google-mind in runes plugin#10

Merged
hhk7734 merged 6 commits into
mainfrom
add-google-mind-skill
Jun 15, 2026
Merged

NO-ISSUE: feat(skills): register review-with-google-mind in runes plugin#10
hhk7734 merged 6 commits into
mainfrom
add-google-mind-skill

Conversation

@nulledge

@nulledge nulledge commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What

Registers the review-with-google-mind skill into the runes plugin. It's a lens that applies Google's published engineering practices (the Code Reviewer's Guide and CL Author's Guide) to whatever the user is reviewing, authoring, or deciding — invoked explicitly via /review-with-google-mind.

Added to both synced locations, kept byte-identical per scripts/check-skills-sync.sh:

  • skills/review-with-google-mind/
  • plugins/runes/skills/review-with-google-mind/

Each contains SKILL.md + references/reviewer-guide.md + references/author-guide.md.

Naming

Originally registered as google-mind; renamed to review-with-google-mind per team review feedback (the bare name didn't convey the skill's purpose).

Conformance to runes:writing-skills

  • Directory structure follows the skill's spec: SKILL.md plus heavy-reference files (the two guides are 325 / 216 lines).
  • Frontmatter valid (761 chars, under the 1024 limit).
  • The skill-creator evals/ dir was deliberately omitted — no other runes skill ships one, and runes validates skills via subagent pressure scenarios, not a JSON eval suite.

Version bump

Licensing (CC BY 3.0)

The bundled Google eng-practices content carries explicit attribution + a CC BY 3.0 license link + an "adapted, not verbatim" notice, and a matching NOTICE.md entry (mirrors the existing superpowers/MIT pattern).

Verification

  • scripts/check-skills-sync.sh passes (both copies identical).
  • All four manifests parse as valid JSON.
  • GitHub Copilot review loop run to termination ("generated no new comments", 0 open threads).

🤖 Generated with Claude Code

Add the google-mind skill (a lens applying Google's eng-practices Code Reviewer's and CL Author's guides) to both skills/ and plugins/runes/skills/, kept byte-identical per scripts/check-skills-sync.sh.

Conforms to runes:writing-skills directory structure: SKILL.md plus references/{reviewer,author}-guide.md as heavy-reference files. The skill-creator evals/ dir is omitted, since no other runes skill ships one and runes validates skills via subagent pressure scenarios rather than a JSON eval suite.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Minor bump for the google-mind skill addition, across all four manifests (marketplace.json, .claude-plugin/plugin.json, .codex-plugin/plugin.json, gemini-extension.json). Follows the convention from #6 of a minor bump for feature additions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new writing/review “lens” skill (google-mind) to the Runes skill set, shipping it in both the repo-root skills/ directory and the plugin-distributed plugins/runes/skills/ directory, and bumps plugin/marketplace versions for the feature addition.

Changes:

  • Added the google-mind skill (SKILL.md) to both synced skill locations.
  • Bundled full-reference documents for Google’s Reviewer/Author guides under references/.
  • Bumped Runes version from 0.3.2 to 0.4.0 across the four JSON manifests.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
skills/google-mind/SKILL.md New skill definition + usage guidance and reference pointers.
skills/google-mind/references/reviewer-guide.md Added full-reference reviewer guide content (CC-BY sourced).
skills/google-mind/references/author-guide.md Added full-reference author guide content (CC-BY sourced).
plugins/runes/skills/google-mind/SKILL.md Synced copy of the new skill for the distributed plugin.
plugins/runes/skills/google-mind/references/reviewer-guide.md Synced copy of reviewer reference for the distributed plugin.
plugins/runes/skills/google-mind/references/author-guide.md Synced copy of author reference for the distributed plugin.
plugins/runes/.codex-plugin/plugin.json Version bump to 0.4.0.
plugins/runes/.claude-plugin/plugin.json Version bump to 0.4.0.
gemini-extension.json Version bump to 0.4.0.
.claude-plugin/marketplace.json Marketplace version bump to 0.4.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread skills/google-mind/SKILL.md Outdated
Comment thread plugins/runes/skills/google-mind/SKILL.md Outdated
Comment thread skills/google-mind/references/reviewer-guide.md Outdated
Comment thread plugins/runes/skills/google-mind/references/reviewer-guide.md Outdated
Comment thread skills/google-mind/references/author-guide.md Outdated
Comment thread plugins/runes/skills/google-mind/references/author-guide.md Outdated
Comment thread skills/google-mind/references/author-guide.md Outdated
Comment thread plugins/runes/skills/google-mind/references/author-guide.md Outdated
nulledge and others added 2 commits June 15, 2026 09:38
…d author guide

Copilot review: the First Line bullet read "Follow by empty line." (ungrammatical); the body text below it says "followed by a blank line." Corrected to "Followed by an empty line." in both synced copies.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot review (CC BY 3.0 compliance): the bundled Google eng-practices content lacked a license link and an explicit adapted/changed notice, and the repo's third-party attribution file (NOTICE.md) had no entry for it.

- SKILL.md / reference headers: add explicit attribution (Google LLC, guide titles), a link to the CC BY 3.0 license, and an explicit 'adapted/distilled, not verbatim' notice. Also corrected the SKILL.md claim that references hold 'the full text'/'exact wording' — they are distilled, not verbatim.

- NOTICE.md: add a Google eng-practices CC BY 3.0 entry, matching the existing superpowers/MIT attribution pattern.

Applied identically to both synced copies (check-skills-sync passes).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Comment thread skills/google-mind/SKILL.md Outdated
Comment thread plugins/runes/skills/google-mind/SKILL.md Outdated
…icitly

Copilot review: the "(see NOTICE.md)" pointer is a dead-end from inside the packaged plugin (NOTICE.md lives at the repository root, not under plugins/runes/). Made the location explicit so plugin consumers know where to find it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

…mind

Team review feedback: the bare name "google-mind" didn't convey what the skill is for. Renamed to "review-with-google-mind" so the identifier communicates its purpose — a Google eng-practices review lens.

Renamed both synced skill dirs (git mv preserves history) and updated the frontmatter name, in-body invocation references (/review-with-google-mind), the H1 title, and the NOTICE.md attribution paths. check-skills-sync passes; frontmatter stays within the 1024-char limit.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nulledge nulledge changed the title NO-ISSUE: feat(skills): register google-mind in runes plugin NO-ISSUE: feat(skills): register review-with-google-mind in runes plugin Jun 15, 2026
@nulledge nulledge requested a review from hhk7734 June 15, 2026 13:08
@hhk7734 hhk7734 merged commit 285db4b into main Jun 15, 2026
1 check passed
@hhk7734 hhk7734 deleted the add-google-mind-skill branch June 15, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants