Skip to content

Make terminfo role idempotent #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remmelt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make terminfo role idempotent #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions roles/terminfo/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,25 @@
changed_when: false
check_mode: false

- name: Read remote terminfo entry
ansible.builtin.command:
argv:
- "{{ terminfo_infocmp_cmd }}"
- -x
- "{{ terminfo_term_name }}"
register: terminfo_remote_infocmp_result
changed_when: false
failed_when: false

@moreati moreati Nov 19, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not keen on this. What if infocmp isn't found? Or some file permission error occurs?

check_mode: false

- name: Save terminfo entry
ansible.builtin.command:
argv:
- "{{ terminfo_tic_cmd }}"
- -x
- "-"
stdin: "{{ terminfo_infocmp_x_result.stdout }}"
when: >
terminfo_remote_infocmp_result.rc != 0 or
terminfo_infocmp_x_result.stdout != terminfo_remote_infocmp_result.stdout
changed_when: true