Add QMux over WebSocket draft#29
Conversation
QMux (draft-ietf-quic-qmux-01) defines bindings over TCP and TLS but not over WebSocket, since that is out of the QUIC WG charter scope. moq-lite already relies on a WebSocket binding (and moq-dev/web-transport's rs/qmux crate implements one), so this adds a standalone, application-agnostic draft specifying it. Key points: - One WebSocket binary message carries one QMux Record's frames; the Record Size field is omitted because the WS message boundary delimits it. This relies on the Record layer introduced in qmux-01. - Sec-WebSocket-Protocol carries the application ALPN alone (e.g. moq-transport-18); the QMux version is implied by the application protocol, matching the QMux-over-TLS convention. - Text messages are forbidden; keep-alive uses WebSocket Ping/Pong since WebSocket has no built-in idle timeout; datagrams are not available on a reliable, ordered transport. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 44 minutes and 27 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request introduces a new IETF draft document 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kixelated
left a comment
There was a problem hiding this comment.
This document is far longer than it needs to be. Get to the chase and don't repeat qmux shit.
Really it should be summarized as:
- use subprotocol instead of ALPN
- each websocket message is a qmux record
And any websocket specific stuff, IDK. Don't repeat stuff in the qmux draft, just link to it instead.
…agrams - Abstract: drop the in-the-weeds Record/Size mechanism detail. - Subprotocol Identifier: state that the app protocol id selects the QMux version (moq-transport-18 -> qmux-01) with no separate version negotiation. - Datagrams: support all QMux features instead of prohibiting datagrams; they are negotiated and encoded as in qmux and carried in binary messages, delivered reliably/in-order as is inherent to a reliable byte-stream binding. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The loss of QUIC's unordered/unreliable semantics is inherent to qmux and already documented there; no need to restate it in this binding. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
What
Adds a new standalone Internet-Draft,
draft-lcurley-qmux-websocket.md, specifying how to run QMux over WebSocket.Why
QMux draft-ietf-quic-qmux-01 defines bindings over TCP and TLS but deliberately leaves out WebSocket (out of QUIC WG charter scope). moq-lite already depends on a WebSocket binding, and
moq-dev/web-transport'srs/qmuxcrate implements one. This hoists that mapping into a reusable, application-agnostic spec that moq-lite (and any other QUIC-over-QMux application) can reference instead of inlining it.Key design points
Frames; the RecordSizefield is omitted because the WS message boundary already delimits it. This depends on the Record layer introduced in qmux-01.Sec-WebSocket-Protocolcarries the application ALPN alone (e.g.moq-transport-18), identical to native QUIC. The QMux version is implied by the application protocol, matching the QMux-over-TLS convention rather than carrying a version token on the wire.qmux-01only; qmux-00 and the legacywebtransportwire format are intentionally not documented.Notes for reviewers
make draft-lcurley-qmux-websocket.txt(kramdown-rfc → xml2rfc).🤖 Generated with Claude Code