fix(Sources): CompilationUnit w/ source + Recursive lookup - #266
Merged
Conversation
Member
Author
|
Had to patch with moosetechnology/FAST#131 to make it work on Moose 12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #263
Reusing
FamixTHasImmediateSourcefrom Famix is practical, but the contract doesn't hold for FAST: only the root entity has the source.This fix is a bit of a shim: we override
sourceTexton entities that use the trait to lookup on parent when it doesn't have the source.Some unfortunate Tonel noise in FAST-Java-Model-Extension package...