Skip to content

chore: replace live-server with Vite, bump deps, remove stale test libs, add .nvmrc - #58

Open
lmken wants to merge 2 commits into
mainfrom
SE-1055-1059/dependency-cleanup-improvements
Open

chore: replace live-server with Vite, bump deps, remove stale test libs, add .nvmrc#58
lmken wants to merge 2 commits into
mainfrom
SE-1055-1059/dependency-cleanup-improvements

Conversation

@lmken

@lmken lmken commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Addresses SE-1055 through SE-1059. Branched off #51 to layer on top of those dependency bumps.

  • SE-1055 — Replace unmaintained live-server with Vite 7.3.1 in moonpay-websdk-buy and moonpay-websdk-sell. Adds vite.config.js to each project (port 8080, auto-open). Updates root build script to include both WebSDK projects. Eliminates all live-server audit vulnerabilities and makes the WebSDK projects consistent with the 4 React projects.
  • SE-1056 — Bump dotenv 16.4.5 → 17.3.1 in server/.
  • SE-1057 — Bump web3 4.13.0 → 4.16.0 in hosted-wallet-page/.
  • SE-1058 — Remove @testing-library/jest-dom, @testing-library/react, and @testing-library/user-event from all 4 React projects. No test files exist in the repo — these were CRA scaffolding leftovers.
  • SE-1059 — Add .nvmrc (Node 20) to repo root.

Test plan

  • npm install completes cleanly
  • npm run build succeeds for all 6 projects (4 React + 2 WebSDK)
  • npm start --workspace=moonpay-websdk-buy serves on port 8080
  • npm start --workspace=moonpay-websdk-sell serves on port 8080
  • npm start --workspace=server starts the signing server
  • npm audit shows only the 2 false-positive name-squatting alerts (unfixable)

Closes #53, #54, #55, #56, #57

🤖 Generated with Claude Code

@linear

linear Bot commented Apr 1, 2026

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Apr 1, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updateddotenv@​16.4.5 ⏵ 17.3.199100100 +194100

View full report

@socket-security

socket-security Bot commented Apr 1, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm web3

Location: Package overview

From: package-lock.jsonnpm/web3@4.16.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/web3@4.16.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

…x CORS

- Bump vite 6.0.0 → 7.3.1 and @vitejs/plugin-react 4.3.4 → 5.2.0 (fixes esbuild/rollup CVEs)
- Bump express 4.21.0 → 4.22.1 (fixes cookie, path-to-regexp, qs, body-parser CVEs)
- Bump react-router-dom 6.26.2 → 6.30.3 (fixes XSS via open redirect GHSA-2w69-qvjg-hvjx)
- Remove unused @moonpay/moonpay-node from 3 frontend projects (backend SDK, never imported)
- Add http://localhost:8080 to default CORS origins so WebSDK demos work out of the box

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@lmken
lmken force-pushed the SE-1013/bump-deps-fix-vulnerabilities branch from 43ad606 to 70fa99b Compare April 23, 2026 21:10
…bs, add .nvmrc

SE-1055: Replace unmaintained live-server with Vite in moonpay-websdk-buy and
moonpay-websdk-sell. Adds vite.config.js to each, updates root build script to
include both WebSDK projects.

SE-1056: Bump dotenv 16.4.5 → 17.3.1 in server.

SE-1057: Bump web3 4.13.0 → 4.16.0 in hosted-wallet-page.

SE-1058: Remove unused @testing-library/jest-dom, @testing-library/react, and
@testing-library/user-event from all four React projects (no test files exist).

SE-1059: Add .nvmrc (Node 20) to repo root.

Closes #53, #54, #55, #56, #57

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lmken
lmken force-pushed the SE-1055-1059/dependency-cleanup-improvements branch from 5343b0c to bfd2c29 Compare April 23, 2026 21:11
Base automatically changed from SE-1013/bump-deps-fix-vulnerabilities to main April 24, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant