Repository navigation
Conversation
DrmRenderer::DrmProperty uses std::optional but drm.h relied on it being
pulled in transitively by another header. This isn't guaranteed and fails
to compile with GCC 13 / libstdc++ on aarch64:
drm.h:89:14: error: 'optional' in namespace 'std' does not name a template type
Include <optional> explicitly alongside the other standard-library headers.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DrmRenderer::DrmPropertyusesstd::optionalbutdrm.hnever includes<optional>, relying on it being pulled in transitively by another header. That isn't guaranteed and fails to compile with GCC 13 / libstdc++ on aarch64:The sibling header
eglimagefactory.halready includes<optional>explicitly for the same reason. This adds the include todrm.halongside the other standard-library headers.