Repository navigation
Add missing IDX_DS_ADAPTIVE_TRIGGERS sentinel to packetTypesGen3..7 - #168
Merged
cgutman merged 1 commit intoOct 26, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
IDX_DS_ADAPTIVE_TRIGGERS(12) was added topacketTypesGen7Enc[],packetTypesGen3[],packetTypesGen4[],packetTypesGen5[], andpacketTypesGen7[]remained at 12 entries (0..11). BecauseneedsAsyncCallback()andqueueAsyncCallback()indexpacketTypes[IDX_DS_ADAPTIVE_TRIGGERS]unconditionally, non-encrypted/older control streams read one element past the end of those tables.Add the missing
-1sentinel entry forIDX_DS_ADAPTIVE_TRIGGERStopacketTypesGen3[],packetTypesGen4[],packetTypesGen5[], andpacketTypesGen7[].