Skip to content

fix MacOS wait PID failure#445

Merged
Guest0x0 merged 1 commit into
mainfrom
fix-process-wait-random-failure
Jun 24, 2026
Merged

fix MacOS wait PID failure#445
Guest0x0 merged 1 commit into
mainfrom
fix-process-wait-random-failure

Conversation

@Guest0x0

@Guest0x0 Guest0x0 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

A recent refactor wrongly dropped the fix in #88. This PR re-introduce the fix in #88. Instead of perform a blocking wait, this PR uses small timeout + retry to work around the race window between kevent failing with ESRCH and the child process enter waitable state.

@Guest0x0 Guest0x0 force-pushed the fix-process-wait-random-failure branch from 9caf7ff to df62be4 Compare June 24, 2026 08:30
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 592

Coverage decreased (-0.02%) to 77.134%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: 5 uncovered changes across 1 file (8 of 13 lines covered, 61.54%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
src/internal/event_loop/process_unix.mbt 5 0 0.0%
Total (3 files) 13 8 61.54%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
src/internal/event_loop/process_unix.mbt 1 41.94%

Coverage Stats

Coverage Status
Relevant Lines: 4627
Covered Lines: 3569
Line Coverage: 77.13%
Coverage Strength: 72904.66 hits per line

💛 - Coveralls

@Guest0x0 Guest0x0 merged commit 6165b92 into main Jun 24, 2026
18 checks passed
@Guest0x0 Guest0x0 deleted the fix-process-wait-random-failure branch June 24, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants