Skip to content

Fix quote attribution contrast - #125

Merged
moomooskycow merged 1 commit into
masterfrom
fix/vanity-quote-contrast
Jul 10, 2026
Merged

Fix quote attribution contrast#125
moomooskycow merged 1 commit into
masterfrom
fix/vanity-quote-contrast

Conversation

@moomooskycow

Copy link
Copy Markdown
Owner

Goal

Clear Vanity's pre-existing deterministic Allie blocker before landing the DigitalOcean Canary parity change.

Change

Use Aesthetic's existing --ae-ink-muted token for the 12px quote attribution instead of --ae-ink-faint.

  • light: #737373 on #fcfcfc = 4.62:1
  • dark: #8f8f8f on #141414 = 5.70:1

The separate icon-contrast and pause-control findings remain out of scope.

Proof

  • ./scripts/check.sh — 15/15
  • local rendered Allie: exit 0, deterministic failures 0, WCAG failures 0
  • previous mainline finding: #q-attr, 2.45:1, run 29061145171 / artifact 8215470534

Agent: vanity-parity-implementer
Agent-Surface: Codex CLI
Agent-Model: openai/gpt-5.4
Agent-Task: vanity-migration-canary

Use Aesthetic's existing muted-ink token for the 12px attribution. It measures 4.62:1 on the light paper and 5.70:1 in dark mode, clearing the deterministic WCAG AA blocker without forking the design system.

Agent: vanity-parity-implementer

Agent-Surface: Codex CLI

Agent-Model: openai/gpt-5.4

Agent-Reasoning: high

Agent-Task: vanity-migration-canary
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vanity Ready Ready Preview, Comment Jul 10, 2026 1:06am

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@phrazzld, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b8998db-5ac1-4f40-bcba-3a1027475a1c

📥 Commits

Reviewing files that changed from the base of the PR and between 13cfa62 and d7b165e.

📒 Files selected for processing (1)
  • index.html
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vanity-quote-contrast

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Allie Verification Summary

Status: needs_review

Why: Evidence ran successfully, but review remains: review-needed obligations 11, not-tested obligations 0, WCAG criteria needing review 6.

Manifest: .allie/manifest.yml
Project root: /home/runner/work/vanity/vanity

Blocking evidence: deterministic failures 0, scripted failures 0, infrastructure failures 0, missing required evidence 0.
WCAG matrix: pass 36, fail 0, needs review 6 (criterion-grain, see Review scope below), not tested 0.

Review scope — what still needs review, and why

Three counts answer different questions about the same run and will not match, by design:

  • Verdict-grain: raw needs_review verdicts from this run, before per-criterion aggregation: 11
  • Criterion-grain: WCAG success criteria aggregated to needs_review across every surface/state: 6
  • Profile-scope: obligations this policy profile always designates for human judgment, independent of this run outcome: 46

Not-tested obligations (no verdict recorded this run): 0.

Reporters:

  • JSON summary: reporters/allie-report.json
  • WCAG JSON: reporters/allie-compliance-report.json
  • HTML: reporters/allie-report.html
  • Markdown: reporters/allie-report.md
  • JUnit: reporters/junit.xml
  • SARIF: reporters/allie.sarif

Evidence packet: run/evidence.json
Product map: map/product-map.json
WCAG HTML: report/compliance-report.html
Release summary: release/release-summary.json

This is evidence visibility for accessibility engineering review, not a legal compliance guarantee.


Full evidence packet — screenshot, axe JSON, WCAG drilldown, release projection — is attached as the allie-verify artifact on this run.

@moomooskycow
moomooskycow merged commit 3a2cbc4 into master Jul 10, 2026
5 checks passed
@moomooskycow
moomooskycow deleted the fix/vanity-quote-contrast branch July 10, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant