#251 Fix third party library list - #254
Open
NeillM wants to merge 1 commit into
Open
Conversation
A third party library (php-compatibility) has been removed from the plugin, however it was still referenced in the `thirdpartylibs.xml` This caused there to be some problems when the plugin is installed in Moodle: 1. `grunt watch` did not function correctly 2. codechecker did not pass its own checks
|
I can confirm that this fixes the issue. I was just about to propose the same fix, because having local_codechecker installed was breaking my ability to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A third party library (php-compatibility) has been removed from the plugin, however it was still referenced in the
thirdpartylibs.xmlThis caused there to be some problems when the plugin is installed in Moodle:
grunt watchdid not function correctlyThis is a fix for issue #251