Move API documentation into C# comments and normalize BOMs - #5078
mattleibow wants to merge 1 commit into
Conversation
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 5078PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 5078"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-5078/packages --name skiasharp-pr-5078More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-5078 |
|
📖 Documentation Preview Add the Removing the label removes the preview. While the label is present, each new commit updates it. This comment is automatically updated by the documentation staging workflow. |
📊 SkiaSharp benchmarks — PR #5078⭐ this PR (full source build) vs 🌙 nightly · Linux · Windows · macOS
Highlights⏱️ Time — 🔴 24 slower · 🟢 36 faster
Full per-OS benchmark deltasLinux⏱️ Time (vs 🌙 nightly
Windows⏱️ Time (vs 🌙 nightly
macOS⏱️ Time (vs 🌙 nightly
|
8b39a3d to
3fce2ad
Compare
3fce2ad to
cf2e4ef
Compare
Extract the complete documentation-comment review base from #5064 and normalize its matching UTF-8 BOMs without functional or tooling changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
cf2e4ef to
181f9b3
Compare
Description
Extracts the complete comments-only review base from #5064 and deterministically removes matching UTF-8 BOMs. This standalone PR carries the frozen final XML documentation-comment prose for declarations already present on
main; it contains zero functional or tooling changes.Related issues
Related to #5064
Required skia PR
None.
Areas affected
binding/)externals/skia/src/c,include/c)Changes
None — documentation comments plus deterministic UTF-8 BOM normalization only; no public API or behavior changes.
Testing
Machine-checked partition against immutable source
0e1d5f755cb6b15160832a0fcc117c03719a0e83..06f6413d86bc00eec0d01da2b2e18cec93539f58(frozen treed9b70ef5b518083c699414bdf2985e96a0dda87b):///lines///linesThe partition proof verifies that B and R exactly partition S with no unclassified residual hunk, and applying B plus the complete reconstructed top produces the frozen source tree byte-for-byte. The persistent inventory records 44 R hunk identities, each with an accompanying declaration signature/code-change witness.
A raw-byte BOM inventory compared this PR with frozen source
06f6413d86bc00eec0d01da2b2e18cec93539f58. It authorizes and removes UTF-8 BOMs from 199 paths where this PR hadEF BB BFand frozen source does not. (The immutable comparison produced 199, rather than the originally estimated 200; the three other BOM-bearing changed files retain BOMs in frozen source and were not changed.) The validator proves every remaining non-documentation byte equalsmain, all changed paths are existing.csfiles, and no unlisted BOM changed.Completed
dotnet cake --target=externals-download;dotnet cake --target=docs-format-docspassed (the uninitialized docs submodule has no XML type files to scan). Built the core binding targetingnet10.0.Ran
pwsh -NoLogo -NoProfile -File ./utils/generate.ps1after initializing Skia and its DEPS checkout. SHA-256 snapshots before and after confirm generated files are byte-identical, including the generated documentation trivia.Checklist
Changesabove lists all public API and behavioral changes (or "None.")mono/skiaPR linked above and bindings regenerated