fix(cli-repl): correctly return false from enableTelemetry setting when forceDisableTelemetry is set MONGOSH-1141

[nbbeeken]

When forceDisableTelemetry is set don't consult the user preferences just return false. Fixes misleading state.

[Copilot]

Pull request overview

This PR fixes the CLI REPL configuration behavior so that when forceDisableTelemetry is in effect, querying enableTelemetry reflects the enforced runtime state (i.e., returns false) rather than the user preference value, preventing misleading configuration output.

Changes:

• Special-case getConfig('enableTelemetry') to return false when forceDisableTelemetry is set.
• Refactor the setConfig('enableTelemetry', ...) guard to run before mutating config state (behavior preserved, but clearer control flow).
• Add a regression test ensuring config.get("enableTelemetry") prints false under a global forceDisableTelemetry: true config.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/cli-repl/src/cli-repl.ts	Ensures enableTelemetry reads as false when telemetry is force-disabled; keeps writes blocked.
packages/cli-repl/src/cli-repl.spec.ts	Adds coverage verifying config.get("enableTelemetry") returns false under forced-disable telemetry.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[alenakhineika]

Can we leverage your PR to clean up this? :) https://github.com/mongodb-js/mongosh/blob/main/packages/cli-repl/src/cli-repl.ts#L221-L224 or crate a follow-up PR/ticket to not forget again.

Would be great to introduce a single isTelemetryEnabled() helper that checks forceDisableTelemetry and enableTelemetry config value, and have all callers defer to it. We have these checks in multiple places already, e.g. the fetch closure, setTelemetryEnabled, enableTelemetry, maybe more. Combining both would give us the single source of truth.

[nbbeeken]

Yea that's fair, I'll investigate what that would take

[nbbeeken]

Because of async-ness I had to change some functions return type, what do we think? @alenakhineika

[alenakhineika]

This is great 🙌 Thx!