chore: bump ts autocomplete - #2755
Closed
lerouxb wants to merge 5 commits into
Closed
Conversation
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates TypeScript-driven autocomplete dependencies and aligns the codebase/tests with updated Node/typing expectations introduced by the newer packages.
Changes:
- Bump
@mongodb-js/mongodb-ts-autocompletefrom^0.4.0to^0.4.1across relevant packages (and lockfile). - Bump
@types/nodefrom^14.14.6to^22.15.30(and lockfile), including new transitiveundici-types. - Adjust tests/runtime code to satisfy newer typings (e.g.,
process.getuid?.(), event busonce()usage, and readonlyprocess.version).
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shell-api/src/integration.spec.ts | Adjusts event-listener wiring to accommodate updated typings around once(). |
| packages/shell-api/package.json | Bumps @mongodb-js/mongodb-ts-autocomplete to ^0.4.1. |
| packages/e2e-tests/test/e2e.spec.ts | Updates root-detection logic to handle optional process.getuid/geteuid typings. |
| packages/e2e-tests/package.json | Bumps @types/node to ^22.15.30. |
| packages/cli-repl/src/mongosh-repl.ts | Reworks interrupt waiting logic to avoid typing issues around events.once(). |
| packages/cli-repl/src/crypt-library-paths.ts | Updates UID/GID access to use optional chaining for newer Node typings. |
| packages/cli-repl/src/cli-repl.spec.ts | Adds TS/ESLint suppressions for readonly process.version mutations in tests. |
| packages/cli-repl/package.json | Bumps @types/node to ^22.15.30. |
| packages/browser-runtime-core/package.json | Bumps @mongodb-js/mongodb-ts-autocomplete to ^0.4.1. |
| packages/autocomplete/package.json | Bumps @mongodb-js/mongodb-ts-autocomplete to ^0.4.1. |
| package.json | Bumps root @types/node to ^22.15.30. |
| package-lock.json | Locks updated versions for autocomplete packages, @types/node, and transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) { | ||
| return { | ||
| libraryStat: { uid: stat.uid, gid: stat.gid, mode: stat.mode }, | ||
| mongoshStat: { uid: execPathStat.uid, gid: stat.gid }, |
| new Promise<void>((resolve) => | ||
| this.bus.once('mongosh:eval-interrupted', resolve) | ||
| ), | ||
| new Promise(setImmediate), |
| it('emits an event when a deprecated method is called', async function () { | ||
| const deprecatedCall = once(instanceState.messageBus, 'mongosh:api-call'); | ||
| const deprecatedCall = once( | ||
| instanceState.messageBus as any, |
Comment on lines
500
to
503
| delete (process as any).version; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore version is readonly | ||
| process.version = 'v8.0.0'; |
Comment on lines
+517
to
519
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore version is readonly | ||
| process.version = `v${process.versions.node}`; |
Comment on lines
+2868
to
2870
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore version is readonly | ||
| process.version = '18.20.0'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some types changed here which might affect autocomplete so I'm just bumping it now rather than someone else dealing with it later.