chore(release): remove writes to old downloads bucket DEVPROD-17837 - #2518
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes writes to the old downloads bucket as part of a cleanup effort after traffic has been migrated to a new bucket. The changes consolidate AWS credential handling to use session tokens and eliminate redundant upload operations.
- Removes all references to the old download center bucket and its associated AWS credentials
- Consolidates to use a single set of AWS credentials with session token support
- Updates configuration files and environment variable mappings to reflect the new credential structure
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/build/test/helpers.ts | Adds session token to test configuration |
| packages/build/src/run-draft.ts | Removes old bucket upload function and adds session token parameter |
| packages/build/src/publish-mongosh.ts | Updates constructor to use session token instead of old bucket credentials |
| packages/build/src/index.ts | Consolidates AWS credential validation to single set with session token |
| packages/build/src/download-center/config.ts | Removes old bucket operations and updates to use session token |
| packages/build/src/download-center/artifacts.ts | Removes old upload function and updates remaining function to use session token |
| packages/build/src/config/redact-config.spec.ts | Adds session token to redacted config list |
| packages/build/src/config/config.ts | Updates Config interface to remove old credentials and add session token |
| config/build.conf.js | Updates environment variable mappings for new credential structure |
| .github/workflows/update-cta.yml | Updates workflow to use new environment variable names |
| .evergreen.yml | Updates CI configuration to use new environment variable names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| acl: 'private', | ||
| } | ||
| ), | ||
| ]); |
There was a problem hiding this comment.
Using Promise.all with a single operation is unnecessary. The array wrapper can be removed since there's only one upload operation remaining.
There was a problem hiding this comment.
yeah you can just await dlcenterArtifacts.uploadAsset( the same way the code await dlcenterArtifactsNew.uploadAsset( did that was removed. And remove the Promise.all.
There was a problem hiding this comment.
I realized this was a mistake to remove thanks to this comment, we do need the Promise.all because we need to keep the configuration file upload!
613f52e to
b036d01
Compare
b036d01 to
208f46e
Compare
This commit removes all writes to the old downloads bucket. Traffic has been cut over for quite some time now, so we should no longer need this code.
208f46e to
7402956
Compare
This commit removes all writes to the old downloads bucket. Traffic has been cut over for quite some time now, so we should no longer need this code.