Skip to content

chore(release): remove writes to old downloads bucket DEVPROD-17837 - #2518

Merged
gagik merged 1 commit into
mongodb-js:mainfrom
drichmdb:DEVPROD-17837
Aug 20, 2025
Merged

chore(release): remove writes to old downloads bucket DEVPROD-17837#2518
gagik merged 1 commit into
mongodb-js:mainfrom
drichmdb:DEVPROD-17837

Conversation

@drichmdb

Copy link
Copy Markdown
Collaborator

This commit removes all writes to the old downloads bucket. Traffic has been cut over for quite some time now, so we should no longer need this code.

Copilot AI review requested due to automatic review settings August 18, 2025 21:48
@drichmdb
drichmdb requested a review from a team as a code owner August 18, 2025 21:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes writes to the old downloads bucket as part of a cleanup effort after traffic has been migrated to a new bucket. The changes consolidate AWS credential handling to use session tokens and eliminate redundant upload operations.

  • Removes all references to the old download center bucket and its associated AWS credentials
  • Consolidates to use a single set of AWS credentials with session token support
  • Updates configuration files and environment variable mappings to reflect the new credential structure

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/build/test/helpers.ts Adds session token to test configuration
packages/build/src/run-draft.ts Removes old bucket upload function and adds session token parameter
packages/build/src/publish-mongosh.ts Updates constructor to use session token instead of old bucket credentials
packages/build/src/index.ts Consolidates AWS credential validation to single set with session token
packages/build/src/download-center/config.ts Removes old bucket operations and updates to use session token
packages/build/src/download-center/artifacts.ts Removes old upload function and updates remaining function to use session token
packages/build/src/config/redact-config.spec.ts Adds session token to redacted config list
packages/build/src/config/config.ts Updates Config interface to remove old credentials and add session token
config/build.conf.js Updates environment variable mappings for new credential structure
.github/workflows/update-cta.yml Updates workflow to use new environment variable names
.evergreen.yml Updates CI configuration to use new environment variable names

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

acl: 'private',
}
),
]);

Copilot AI Aug 18, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Promise.all with a single operation is unnecessary. The array wrapper can be removed since there's only one upload operation remaining.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you can just await dlcenterArtifacts.uploadAsset( the same way the code await dlcenterArtifactsNew.uploadAsset( did that was removed. And remove the Promise.all.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this was a mistake to remove thanks to this comment, we do need the Promise.all because we need to keep the configuration file upload!

@drichmdb drichmdb changed the title DEVPROD-17837: remove writes to old downloads bucket chore(release): remove writes to old downloads bucket DEVPROD-17837: Aug 18, 2025
@drichmdb drichmdb changed the title chore(release): remove writes to old downloads bucket DEVPROD-17837: chore(release): remove writes to old downloads bucket DEVPROD-17837 Aug 18, 2025
@drichmdb
drichmdb force-pushed the DEVPROD-17837 branch 2 times, most recently from 613f52e to b036d01 Compare August 18, 2025 23:45
This commit removes all writes to the old downloads bucket. Traffic has been
cut over for quite some time now, so we should no longer need this code.
@gagik
gagik merged commit beda48b into mongodb-js:main Aug 20, 2025
124 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants