Repository navigation
build(embed): pin node 24.19.0 and pnpm 11.20.0 to match ui - #22
Merged
Merged
Conversation
The release workflow publishes tokenless via OIDC trusted publishing, but pnpm 9.15 has no native OIDC support, so its publish delegated to npm and leaked pnpm's own --no-git-checks flag, aborting publish with EUNKNOWNCONFIG. pnpm 11.20 does trusted publishing and provenance natively. Aligns the toolchain with the ui repo: node 24.19.0 / pnpm 11.20.0 via a shared .tool-versions file. Adds allowBuilds for esbuild (pnpm 11 blocks dependency lifecycle scripts by default) and drops the manual npm upgrade step, now redundant since node 24 bundles npm 11.x and pnpm publishes directly.
Credgate
requested review from
alastaird-monad,
andrewc-monad,
brenth-monad,
mattj-monad,
mon-aneesh and
saikapuluru99
as code owners
August 11, 2026 19:15
andrewc-monad
approved these changes
Aug 11, 2026
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Node.js and pnpm toolchain to enable tokenless OIDC trusted publishing/provenance with pnpm (avoiding npm delegation issues) and to align versions with the UI repo.
Changes:
- Pin pnpm to
11.20.0and tighten Node engine to24.19.0 < 25inpackage.json. - Add
.tool-versionsand switch GitHub Actions to read Node version from it. - Add
allowBuildsforesbuildto accommodate pnpm 11’s default build-script restrictions, and remove the redundant npm-upgrade step from the release workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pnpm-workspace.yaml |
Allows esbuild lifecycle scripts under pnpm 11 via allowBuilds. |
package.json |
Pins pnpm version and updates Node/pnpm engine constraints. |
.tool-versions |
Introduces a shared Node/pnpm version source for local tooling and CI. |
.github/workflows/release.yml |
Uses .tool-versions for Node selection and removes npm upgrade step. |
.github/workflows/ci.yml |
Uses .tool-versions for Node selection in CI jobs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
26
to
29
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version-file: '.tool-versions' | ||
| cache: pnpm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow publishes tokenless via OIDC trusted publishing, but pnpm 9.15 has no native OIDC support, so its publish delegated to npm and leaked pnpm's own --no-git-checks flag, aborting publish with EUNKNOWNCONFIG. pnpm 11.20 does trusted publishing and provenance natively.
Aligns the toolchain with the ui repo: node 24.19.0 / pnpm 11.20.0 via a shared .tool-versions file. Adds allowBuilds for esbuild (pnpm 11 blocks dependency lifecycle scripts by default) and drops the manual npm upgrade step, now redundant since node 24 bundles npm 11.x and pnpm publishes directly.