Fix OrderFileHandler incorrect log level & increase non debug log level to warning - #1414
Fix OrderFileHandler incorrect log level & increase non debug log level to warning#1414gecolay wants to merge 1 commit into
Conversation
3cb06b6 to
1bc8865
Compare
|
hi @gecolay thanks for the pull request. i will rebuild the pr a little bit. changing to warning in the code is not a good idea, i need the logs from info as well for debugging purpose. if a merchant did not enabled debug mode but wants to know what is happend with his failed order i can see there at least which process was triggered and when the error was there. it is helpfull for debugging for me. i will rewrite the handler, so you can configure a loglevel like a regular log handler from monolog. and debug mode will overwrite your settings. i will make a new pr okay? |
Isn't that what the "debug mode" in the settings is for? Mollie currently extremly spams the logs in prod, especially since the new structure, where a separate log file is created for each order.
A error will still show up in the logs, otherwise the merchant would have to enable the debug mode.
I guess this will work for me (I still think that without debug mode, it should at least be a warning level, otherwise the logs grow enormously.) |
|
@gecolay the issue is, that not every shop have enabled debug mode. and usually an issue happens and THEN they activate it and ask me what went wrong. so i add info logs and warning etc and debug mode is for more detailed logs. it helps me with the support. not all merchants have a developer sitting with them some merchants are normal users and they ask me over support chat what went wrong, ineed a way to tell them even if the debug logs are disabled. the spam is intended. we had issues where workers were not enabled in shop, was hard to debug without logs. we had issues where a shop was not reachable from outside so webhook didnt come in. its hard to debug if you dont have logs. so now i have many logs and i can tell then when something does not work. |
warninginstead ofinfoas theinfolog level spam's the logs a lot