[codex] fix desktop release build#68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS release build failure from the
v0.0.9release workflow by bringing the desktop setup and recording-start wiring back in sync with the current app and session APIs.Root Cause
The desktop UI had gained recognizer setup callbacks and local model UI, but
AppModelno longer carried the setup state those views expected. At the same time, recording start still passed a plain locale string even thoughSessionRunner::startnow requires aSessionConfig.Changes
AppModel, including recognizer selection, local model status, download state, and completion checks.TranscriptViewfrommain.rs.SessionConfiggenerated from the selected setup state.Validation
nix develop .#ci --quiet -c cargo fmt --checknix develop .#ci --quiet -c cargo check -p wisp-desktop --features gpui/runtime_shadersnix develop .#ci --quiet -c cargo test -p wisp-desktop --features gpui/runtime_shaders