Skip to content

[codex] fix desktop release build#68

Merged
pranc1ngpegasus merged 1 commit into
mainfrom
codex/fix-wisp-desktop-release-build
Jul 7, 2026
Merged

[codex] fix desktop release build#68
pranc1ngpegasus merged 1 commit into
mainfrom
codex/fix-wisp-desktop-release-build

Conversation

@pranc1ngpegasus

Copy link
Copy Markdown
Member

Summary

Fixes the macOS release build failure from the v0.0.9 release workflow by bringing the desktop setup and recording-start wiring back in sync with the current app and session APIs.

Root Cause

The desktop UI had gained recognizer setup callbacks and local model UI, but AppModel no longer carried the setup state those views expected. At the same time, recording start still passed a plain locale string even though SessionRunner::start now requires a SessionConfig.

Changes

  • Restore setup state on AppModel, including recognizer selection, local model status, download state, and completion checks.
  • Wire setup refresh, recognizer selection, and local model download callbacks into TranscriptView from main.rs.
  • Start recordings with a SessionConfig generated from the selected setup state.
  • Make local model size rendering independent of match binding mode.

Validation

  • nix develop .#ci --quiet -c cargo fmt --check
  • nix develop .#ci --quiet -c cargo check -p wisp-desktop --features gpui/runtime_shaders
  • nix develop .#ci --quiet -c cargo test -p wisp-desktop --features gpui/runtime_shaders

@pranc1ngpegasus pranc1ngpegasus marked this pull request as ready for review July 7, 2026 00:34
@pranc1ngpegasus pranc1ngpegasus merged commit 182349b into main Jul 7, 2026
2 checks passed
@pranc1ngpegasus pranc1ngpegasus deleted the codex/fix-wisp-desktop-release-build branch July 7, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant