Deprecation and fixes of old or misleading API functions - #50
Merged
Conversation
Owner
Author
|
@Bo0mer , I'd love to get your feedback on this, since it is more disruptive than what I usually introduce. |
mokiat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
gog.PtrOf. New code should use Go's built-innewfunction.Empty<DataStruct>andPreallocated<DataStruct>functions indspackage. The old usage ofNew<DataStruct>, which expected an integer was unintuitive and annoying when an empty one was needed. The new namings should be more descriptive. The oldNew<DataStruct>functions have been deprecated in favour of the new ones.Orfilter - it now returnsfalse, which is the correct behavior.