Repository navigation
Keep empty search feedback readable above the landscape keyboard - #113
Conversation
|
Root verification at exact head Local outcomes: 25 final positives / 12 whole cohorts / 186 restoration checks; four same-instrumentation controls have eight intended failures / zero passes / 68 checks. Fourteen independent final-preservation checks pass, including original modern APKs/all 573 app files and both current IME baselines. Full retained native accounting stays 59 executions / 39 passes / 20 failures / 471 cohort checks; the v2 host-orchestration stop is a separate seven-check restored boundary, with its registry still incomplete. JVM343 executed without failures/errors/skips; both build variants succeed; lint 0 errors/56 warnings each; Python135 per mode remains exact-source reuse from Actual exact-head |
|
Independent correctness/security and collector/test-soundness audit completed at exact head Root has freshly confirmed the unchanged clean local/GitHub head and actual exact-head |
moikdev
left a comment
There was a problem hiding this comment.
Final root gate verification at b74893cd3cafe424558d8ee60f58713abbfe9a70 against 102ec17d226a1f5496479088a9277e8f8c47fdc6.
Both required independent full-change audits used actual gpt-6.1-sol / high reasoning effort, worked read-only without delegation/companion consultation, and returned no actionable findings: correctness/security pr113-correctness-b74893cd-v1-high; UX/test/provenance pr113-ux-b74893cd-v1-high. UX viewed all 84 real PNGs; both verified source/binary/evidence identities and accounting. These were source/evidence inspections, not reviewer test executions.
Root freshly confirmed clean local and unchanged GitHub head/base, all 254 frozen source hashes, actual exact-head pull_request Android run42078762341 completed/success, and separate local/android58176983369 success. Recorded local evidence: JVM343 executed; Python135/mode at unchanged Python source; both build variants; lint0 errors/56 warnings each; 25 native positives /12 cohorts /186 restoration checks; eight intended common-instrumentation failures /zero passes /68 checks; fourteen separate final-preservation checks. All 11 original assets/notices remain unchanged. Earlier failed/intermediate cohorts and the incomplete v2 registry remain distinct.
Scoped acceptance covers native Apps/Emoji empty feedback and sequential pointer reachability at the recorded profiles. Nonempty typography, every system-IME transition, Files-toolbar/OEM/TalkBack/physical typing, unseen private-original identity, broader Store parity, #69/#71/#89 and signing/migration remain outside clearance. Merge only this verified reviewed SHA with the expected-head guard.
The launcher and Emoji empty-result messages remain readable above the short-landscape keyboard at 100% and 200%. Compact views show one primary status, retain the original 14 sp / 13 sp font sizes, use 18 sp / 16 sp leading and reclaim 8 dp of the bottom gap. Search/header controls keep their origin and 48 dp targets; footer controls remain reachable by pointer scrolling. Normal viewports retain their helper/count text.
Closes #111 within the observed native Apps/Emoji scope. #69/#71/#89, Files-toolbar variants, broader typography/Store/platform/accessibility and signing/migration limits remain open or unverified.
Validation: 25 final positives / 12 whole cohorts / 186 restoration checks, plus 8 intended old/intermediate failures / zero passes / 68 checks using the same final test APK. Modern landscape/phone/tablet run at 100% / 200%; API 26 adds normal-viewport native smoke; existing Clear, ownership and controlled-input regressions are retained. All 14 final preservation checks pass, including all 573 original modern app/evidence files, both original APKs, legacy package absence and current four-field IME settings. Builds succeed; lint 0 errors / 56 warnings per variant; JVM 343 passes; Python 135 per mode is reused with all Python bytes unchanged. Report and full accounting.
Frozen final source
6c5825bf, app66a6965…c524c, test72dc12a…51d2, 254 source inputs and all 11 original packaged assets/notices are verified. Earlier failures, intermediate passing criteria, and the restored-boundary host-orchestration stop remain separate. Hosted exact-head Android and both independent gpt-6.1-sol/high audits are separate merge gates; local results do not certify hosted CI.Actual Android before/after frames: Tinycast_Tablet_API_36 / API 36, 2340×1080 / 420 dpi, selected system keyboard shown. The same final test
72dc12adrives old app974b2faand repaired app66a6965. Query entry and keyboard visibility are controlled setup; line assertions check complete natural extents and fixed point sizes. Old-control screenshots show clipping/absence and ordinary app UI, not app error banners.The same 100% landscape runtime after actual pointer panning exposes the complete 48 dp Emoji favorite target. The header is scrolled out in this later state; the receipt then verifies pointer return to its original position with unchanged query/range/focus/IME. This does not claim simultaneous visibility of all chrome or activation of disabled Copy/favorite actions.
Matching/cleared states are functional smoke rather than full result-row/grid typography coverage. Controlled composition remains a normal-profile regression, with system-IME transition limits still open under #69. No physical typing, full TalkBack/OEM, whole-system/private-original identity or broad Raycast parity claim is added.