Skip to content

test(stage-ui): fix browser fixtures and cleanup - #2492

Merged
leaft merged 1 commit into
moeru-ai:mainfrom
leaft:codex/fix-stage-ui-ci
Sep 9, 2026
Merged

test(stage-ui): fix browser fixtures and cleanup#2492
leaft merged 1 commit into
moeru-ai:mainfrom
leaft:codex/fix-stage-ui-ci

Conversation

@leaft

@leaft leaft commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Description

The Unit Test job reaches stage-ui, then fails and stalls in browser tests. The same failures occur on the parent commit.

  • Use the real consciousness store and Pinia refs in context bridge tests. Check that input requests preserve temperature and top-p.
  • Dispose each bridge and Pinia scope after every test, including failed assertions. This prevents old listeners from receiving later stream events.
  • Create translated module stores during component setup and await card initialization before drawer interactions. Dispose the fixture stores after each test.
  • Remove the Pinia and Mutex replacements from the context bridge fixture.

This change only updates two test files.

Verification

The original fixture reproduced three failures in the two affected files. The updated files pass all 17 tests. The complete CI test command passes 2,534 tests, with one skipped test. Stage-ui passes all 822 tests.

  • NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run --config packages/stage-ui/vitest.config.ts --project browser packages/stage-ui/src/components/misc/character-switcher-drawer.browser.test.ts packages/stage-ui/src/stores/mods/api/context-bridge.contract.browser.test.ts --reporter=verbose
  • NODE_OPTIONS=--no-experimental-webstorage pnpm run test:run
  • pnpm run typecheck
  • pnpm run lint
  • sem diff --staged --no-cosmetics -v --file-exts .ts .tsx, JSON diff, and dependent analysis for mountSwitcher: no blocking findings.
  • git diff --cached --check

GitHub CI also passes on this PR: all nine CI jobs succeeded, including Unit Test.

Additional Context

Reported CI failure · Parent commit failure

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T03:25:18.454645Z 562d9ea PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

@leaft
leaft merged commit 7bcd8e5 into moeru-ai:main Sep 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant