test(stage-ui): fix browser fixtures and cleanup - #2492
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Unit Test job reaches stage-ui, then fails and stalls in browser tests. The same failures occur on the parent commit.
This change only updates two test files.
Verification
The original fixture reproduced three failures in the two affected files. The updated files pass all 17 tests. The complete CI test command passes 2,534 tests, with one skipped test. Stage-ui passes all 822 tests.
NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run --config packages/stage-ui/vitest.config.ts --project browser packages/stage-ui/src/components/misc/character-switcher-drawer.browser.test.ts packages/stage-ui/src/stores/mods/api/context-bridge.contract.browser.test.ts --reporter=verboseNODE_OPTIONS=--no-experimental-webstorage pnpm run test:runpnpm run typecheckpnpm run lintsem diff --staged --no-cosmetics -v --file-exts .ts .tsx, JSON diff, and dependent analysis formountSwitcher: no blocking findings.git diff --cached --checkGitHub CI also passes on this PR: all nine CI jobs succeeded, including Unit Test.
Additional Context
Reported CI failure · Parent commit failure