fix(stage-ui): persist speech provider settings - #2467
Conversation
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04b006bb9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6942c4201b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…er RPC A rejected leader-routed patch left the promise chain permanently rejected, so every later `.then` was skipped and edits stopped saving silently. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
I have applied the fixes from the review comments but could not create a PR due to errors. Please see the local changes in the fork. |
2 participants
Summary
Closes #2447.
Validation
pnpm -F @proj-airi/stage-ui exec vitest run --project browser src/components/scenarios/providers/speech-provider-settings.browser.test.tspnpm -F @proj-airi/stage-ui exec vitest run --project node src/stores/providers/config.test.tspnpm -F @proj-airi/stage-ui typecheckpnpm typecheckpnpm lintVisual changes
No static visual change. The provider settings page now keeps the selected voice settings after navigation.