fix(stage-tamagotchi): stabilize Linux Flatpak/RPM packaging and releases - #2456
Open
0xSelenicDove wants to merge 1 commit into
Open
Conversation
…ases Split from moeru-ai#2278. Bundles the Linux packaging fixes: - Keep only the target architecture's native binaries (onnxruntime-node, uiohook-napi, electron-click-drag-plugin, sharp/libvips) in packaged builds instead of shipping every platform's payload, while fixing an extglob pattern that let the Sharp exclusion swallow the libvips package it needs to keep. - Add a package post-removal hook (deb/rpm) that only removes the update-alternatives target once the AIRI executable is actually gone, so an upgrade no longer leaves broken alternative links or strips /usr/bin/airi mid-upgrade. - Disable electron-updater under Flatpak, since Flatpak owns application installation and updates and must not let electron-updater select a DEB/RPM updater from inside the sandbox. - Add verify-linux-package.ts (+ CI step) to assert the built .deb/.rpm/ Flatpak artifacts expose the expected executable and desktop launcher paths, and a Fedora RPM lifecycle check for install/upgrade/remove. - Give the Linux release build step a bounded 3 GB Node heap and a disk-backed temp directory (a 4 GB ARM64 runner previously exhausted both the default heap and tmpfs during packaging). Rebased onto current main: kept main's package.json version and the `minimatch` catalog entry needed by the new verification scripts; fixed linux-packaging.test.ts, which hardcoded an artifact filename version from when this branch was cut, to read the real package.json version instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split off #2278 per maintainer feedback ("Too big, split."). Bundles the Linux packaging fixes:
/usr/bin/airimid-upgrade.verify-linux-package.ts(+ CI step) to assert the built.deb/.rpm/Flatpak artifacts expose the expected executable and desktop launcher paths, and a Fedora RPM lifecycle check for install/upgrade/remove.Rebased onto current
main: kept main'spackage.jsonversion and added theminimatchcatalog entry needed by the new verification scripts; fixedlinux-packaging.test.ts, which hardcoded an artifact filename version from when this branch was cut, to read the realpackage.jsonversion instead.Test plan
pnpm -F @proj-airi/stage-tamagotchi typecheckpnpm exec eslinton the touched TS/JS filespnpm -F @proj-airi/stage-tamagotchi exec vitest runonlinux-packaging.test.ts,verify-linux-package.test.ts,auto-updater.test.ts(88 passed, 1 Linux-gated skipped on macOS)🤖 Generated with Claude Code