Repository navigation
Conversation
Contributor
Author
|
Mojo-snappy was built against Mojo 1.1.0 with changes to conform to the changelog. However, it is used in pyroquet because parquet uses snappy compression (among others). However, my pyroquet package also imports NuMojo and they don't have a release against Mojo 1.1.0 yet so for now this is blocked but PR 412 should solve this and then both mojo-snappy and pyroquet can be built and distributed through prefix.dev. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep package builds and uploads moving when recipes use different Mojo compiler versions or another runner has already committed the same compatibility metadata.
The Linux failure in run 39267609540 occurs when Pyroquet resolves its dependencies: the locally rebuilt mojo-snappy 0.2.0 requires Mojo 1.1.0, while Pyroquet requires Mojo 1.0.0. Strict channel priority hides the compatible published mojo-snappy build. Isolate each recipe's output channel; the upload helper already discovers packages recursively. Keep Pyroquet's existing pins while its dependency stack awaits published Mojo 1.1-compatible packages.
The earlier macOS failure in run 39098506151 was an empty metadata commit after pulling an identical upstream update. Recheck the staged diff after pulling, preserving errors from the diff command.
Evidence
rattler-buildsolver throughscripts.build-alland fails with the same strict-channel-priority / Mojo 1.1 dependency error.After: The same regression passes with per-recipe output directories. A second test verifies recursive upload discovery.
pixi run python -m unittest discover -s tests -v; repository pre-commit checks pass using Pixi 0.81.0 and the locked environment.Merge Danger
Door: Two-way; both changes can be reverted.
Blast Radius: CI. Build artifacts now live under
output/<recipe>/<platform>/. Recipes resolve dependencies from published or explicitly supplied channels instead of implicitly consuming another recipe's output from the same invocation. This prevents build order from selecting incompatible compiler builds, but dependencies that are not published yet still require an explicit channel. The existing recursive upload helper supports the new layout. No recipe or dependency version changes. The metadata fix handles empty commits, not every concurrent push race.After merge, verify that the build/upload workflow publishes the mojo-snappy 0.2.0 build 1 rebuild from #408, or trigger it on main if needed.