Skip to content

Move packaging to pyproject.toml with version from git tags - #89

Merged
salkinium merged 1 commit into
developfrom
feature/pyproject
Oct 13, 2026
Merged

salkinium merged 1 commit into
developfrom
feature/pyproject

Conversation

@salkinium

@salkinium salkinium commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Finally doing what the main branch started in 2024 and then forgot about, lol. This moves the packaging to pyproject.toml, takes the version from git tags and publishes to PyPI when a v* tag is pushed, same as modm-data does it. No more "Increase version" commits!

  • pyproject.toml with setuptools-git-versioning, same dependencies and entry point as before.
  • pypi.yml workflow replaces deloy.yml and uses trusted publishing instead of the PYPI_PASSWORD secret.
  • lbuild.__version__ stays a plain X.Y.Z, since modm's repo.lb feeds it into StrictVersion, which chokes on 1.23.0.post1+git.abcdef12. lbuild --version prints the full thing.
  • Wheel content is identical to the setup.py one, plus resources/catalog.xml which was missing before, whoops.
  • Unit tests pass from the checkout and against the installed sdist.
  • lbuild discover on modm works with the built wheel.

Missing:

  • There are no git tags in this repo at all, so an untagged build is version 0.0.1. Needs a v1.23.0 tag after merging.
  • Trusted publisher for the pypi.yml workflow and pypi environment needs to be configured on PyPI and GitHub.

Running lbuild from a checkout without installing it now reports version 0.0.0, which modm's minimum version check rejects, so use pip install -e . instead.

This branch was successfully deployed

1 active deployment
pypi — d13791dc Deployed Oct 13, 2026 by salkinium via Upload release to PyPI #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant