Repository navigation
Move packaging to pyproject.toml with version from git tags - #89
Merged
Merged
Conversation
salkinium
force-pushed
the
feature/pyproject
branch
from
October 12, 2026 12:57
65bf915 to
091c16d
Compare
salkinium
force-pushed
the
feature/pyproject
branch
from
October 13, 2026 19:53
091c16d to
d13791d
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally doing what the
mainbranch started in 2024 and then forgot about, lol. This moves the packaging topyproject.toml, takes the version from git tags and publishes to PyPI when av*tag is pushed, same as modm-data does it. No more "Increase version" commits!pyproject.tomlwithsetuptools-git-versioning, same dependencies and entry point as before.pypi.ymlworkflow replacesand uses trusted publishing instead of thedeloy.ymlPYPI_PASSWORDsecret.lbuild.__version__stays a plainX.Y.Z, since modm'srepo.lbfeeds it intoStrictVersion, which chokes on1.23.0.post1+git.abcdef12.lbuild --versionprints the full thing.setup.pyone, plusresources/catalog.xmlwhich was missing before, whoops.lbuild discoveron modm works with the built wheel.Missing:
0.0.1. Needs av1.23.0tag after merging.pypi.ymlworkflow andpypienvironment needs to be configured on PyPI and GitHub.Running lbuild from a checkout without installing it now reports version
0.0.0, which modm's minimum version check rejects, so usepip install -e .instead.