Fix cloudsmith.sh path bug, bump manual scripts to cp314 - #78
Merged
Conversation
Found while auditing this repo the same way as borgmatic-collective/pypi: - cloudsmith.sh cd's into wheelhouse/ but then globbed wheelhouse/*.whl and rm -rf wheelhouse/*.whl, which wouldn't match anything after the cd. Fixed to use the relative *.whl glob (this was already fixed in pypi's copy of the script but never fixed here). - The manual local build scripts (borg_manylinux.sh, borg_musllinux.sh, llfuse_manylinux.sh, llfuse_musllinux.sh, pyyaml.sh, ruamel.yaml.clib.sh) were pinned to cp313/cp312, while docker-borgmatic's Dockerfile is on Python 3.14. Bumped to cp314 to match, same as the automated ci.yaml build already does via its dynamic Dockerfile version detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited this repo the same way I audited borgmatic-collective/pypi. Recipes and requirements.txt are already in sync here (this repo was the source of truth for that fix), but found two smaller issues:
cloudsmith.shcd's intowheelhouse/but then globswheelhouse/*.whlandrm -rf wheelhouse/*.whl— neither matches anything after thecd. Fixed to use the relative*.whlglob (already fixed in pypi's copy of this script, just never fixed in the original here).borg_manylinux.sh,borg_musllinux.sh,llfuse_manylinux.sh,llfuse_musllinux.sh,pyyaml.sh,ruamel.yaml.clib.sh) were pinned tocp313/cp312, whiledocker-borgmatic's Dockerfile is now on Python 3.14 — the automated CI build already tracks this dynamically, these manual scripts didn't. Bumped tocp314.Test plan
cibuildwheelinvocation) and confirm it targets cp314cloudsmith.shagainst a test wheelhouse and confirm the glob now matches files