No 'cpu_time' unless 'cpu_time_per_step' is specified for calcul… - #399
Merged
Conversation
hugo-sigurdson
requested review from
PeterMeisrimelModelon and
efredriksson-modelon
March 16, 2026 09:22
…on option 'clock_step' set to false
PeterMeisrimelModelon
approved these changes
Mar 16, 2026
PeterMeisrimelModelon
left a comment
PeterMeisrimelModelon
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Minor suggestion on changelog.
hugo-sigurdson
force-pushed
the
dev-hs-ept-no-cpu-time-unless-step-time
branch
from
March 16, 2026 09:58
b8f30b3 to
0774c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, we previously assumed that
@Diagnostics.cpu_time_per_stepexisted, meaning we always had@Diagnostics.cpu_time.Now we first check if
@Diagnostics.cpu_time_per_stepis specified.