Revise event iteration and super-dense time instant handling - #2176
Merged
Conversation
Updated recommendations for event iteration and concluded super-dense time instants.
chrbertsch
marked this pull request as ready for review
June 9, 2026 09:34
Contributor
|
The whole paragraph is still non-normative. Is this intended? |
klausschuch
reviewed
Jun 9, 2026
Co-authored-by: Klaus Schuch <klaus.schuch@avl.com>
Tc-Fast
reviewed
Jun 10, 2026
Co-authored-by: Nikolai Fast <n.fast@beckhoff.de>
chrbertsch
commented
Jun 10, 2026
chrbertsch
commented
Jun 10, 2026
| Each super-dense time instant represents a distinct event occurring at the same simulation time. | ||
| If any event originating from the continuous time mode (for a ME FMU) resp. step mode (for a CS FMU) is present, its event iteration must be performed during the first super-dense time instant. | ||
| Each super-dense time instant must conclude with a call to <<fmi3UpdateDiscreteStates>>. | ||
| If any event originating from the continuous time mode (for a ME FMU) resp. step mode (for a CS FMU) is present, it is recommended that its event iteration gets handled during the first super-dense time instant. |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| If any event originating from the continuous time mode (for a ME FMU) resp. step mode (for a CS FMU) is present, it is recommended that its event iteration gets handled during the first super-dense time instant. | |
| If any non-clocked event is present, it is recommended that its event iteration gets handled during the first super-dense time instant. |
Collaborator
Author
There was a problem hiding this comment.
Hans: in Modelica we would handle the clocks fist, and not iterate on the clocks.
Elmir: What about the "not iterate on the clocks" in Modelica.
Hans: For non clocked-part you can have a cascade of events (e.g. for multiple clutches) in an event iteration.
Christian: what about triggered clocks in Modelica?
Hans: they exist also. You have to wait until they are triggered.
chrbertsch
commented
Jun 10, 2026
Tc-Fast
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2158