Skip to content

Use consistent language for "states" - #2074

Draft
Tc-Fast wants to merge 1 commit into
modelica:mainfrom
Tc-Fast:dev
Draft

Use consistent language for "states"#2074
Tc-Fast wants to merge 1 commit into
modelica:mainfrom
Tc-Fast:dev

Conversation

@Tc-Fast

@Tc-Fast Tc-Fast commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Related to #2052

@Tc-Fast
Tc-Fast requested a review from t-sommer November 4, 2025 07:51
@chrbertsch

Copy link
Copy Markdown
Collaborator

Torsten S: I will provide a suggestion based on this, where we have consistency with usage in the XML. I will diskuss this with @Tc-Fast

@chrbertsch

Copy link
Copy Markdown
Collaborator

FMI Design meeting:

We suggest to limit this PR to only make the distinction between state machine modes and other states.
There are more changes necessary to fix inconsistencies w.r.t. continuous(-time), discrete(-time) and clocked variables and states that should be done in a different PR.


[[fmi3Fatal,`fmi3Fatal`]]
`fmi3Fatal`::
The state of all instances of the model is irreparably corrupted.

@chrbertsch chrbertsch Dec 16, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christian: This means something different ...
Klaus: it is the same "state" as in "get state" --> "the internal FMU state"
Christian: in many places it is just called "FMU state". Should we get rid of the "internal"?

@Tc-Fast

Tc-Fast commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

I changed the commit to now only include the distinction between "state machine modes" and other "states".

@chrbertsch

Copy link
Copy Markdown
Collaborator

FMI Design Meeting:
Torsten S: I work on a larger PR to clean up the usage of "state". Could we wait with merging this one?

@Tc-Fast Tc-Fast closed this Feb 3, 2026
@Tc-Fast
Tc-Fast deleted the dev branch February 3, 2026 07:49
@chrbertsch

Copy link
Copy Markdown
Collaborator

@Tc-Fast : should we not leave this open as draft PR until @t-sommer suggests his proposal?

@Tc-Fast
Tc-Fast restored the dev branch February 3, 2026 11:40
@Tc-Fast

Tc-Fast commented Feb 3, 2026

Copy link
Copy Markdown
Contributor Author

I accidently closed it, by deleting my branch. I guess i should use better branch names.

@Tc-Fast Tc-Fast reopened this Feb 3, 2026
@chrbertsch
chrbertsch marked this pull request as draft February 3, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants