Skip to content

fix(codemod): use a junction for the symlink cycle test on Windows #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laoyyu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(codemod): use a junction for the symlink cycle test on Windows #3122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b159c
fix(codemod): use a junction for the symlink cycle test on Windows
laoyyu Oct 29, 2026
76c6846
test(codemod): note the provenance of the 64-entry mutation count
laoyyu Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/codemod/test/v1-to-v2/packageJsonUpdater.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,16 @@ describe('run() manifest integration', () => {
"import { Client } from '@modelcontextprotocol/sdk/client/index.js';\nexport { Client };\n"
);
// A cycle: src/loop -> the project root.
symlinkSync(dir, path.join(dir, 'src', 'loop'), 'dir');
// Creating a 'dir' symlink on Windows requires admin rights or
// Developer Mode; a junction does not and still forms the cycle.
symlinkSync(dir, path.join(dir, 'src', 'loop'), process.platform === 'win32' ? 'junction' : 'dir');

const result = run(v1ToV2Migration, { targetDir: dir, dryRun: false });

// The symlinked re-entry must not be followed: exactly one source file seen.
// (If the guard ever regressed, a manual mutation run on Windows would report 64
// entries here — 63 resolvable reparse-point levels plus the one that fails — and
// a second nested junction would halve the count to 32.)
expect(result.fileResults.map(fr => fr.filePath)).toHaveLength(1);
expect(result.packageJsonChanges?.[0]?.applied).toBe(true);
expect(result.packageJsonChanges?.[0]?.removed).toEqual(['@modelcontextprotocol/sdk']);
Expand Down
Loading