Repository navigation
Keep raw response when pending result decoding fails - #292
Open
EhsanAzish80 wants to merge 4 commits into
Open
EhsanAzish80 wants to merge 4 commits into
EhsanAzish80 wants to merge 4 commits into
Conversation
Contributor
|
Hi @EhsanAzish80, thanks for this PR! I've reviewed it and it looks good to merge. Could you please rebase it onto the latest If you're no longer able to work on this, no problem: just let us know. If we don't hear back in about two weeks, we may carry the change forward in a new PR, with credit to you. |
EhsanAzish80
force-pushed
the
fix/pending-response-diagnostics
branch
from
October 22, 2026 15:27
32433ad to
4fd3fe1
Compare
EhsanAzish80
force-pushed
the
fix/pending-response-diagnostics
branch
from
October 22, 2026 16:49
4fd3fe1 to
277f5b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a response cannot decode as the expected result type,
TypeMismatchErrorincludes the expected type, raw value, and underlying decoding error. This helps diagnose #220 without changing how valid responses decode.The branch is updated to current
mainand includes the Ubuntu CI setup and client-test timing fixes shared with #307.Tests: malformed, valid, and non-JSON response cases passed locally before this update. All six CI jobs passed on
5ca6ff8, including Ubuntu tests. AI helped write the tests; I ran them.