fix(filesystem): reject existing move destinations#4531
Open
dev-willbird1936 wants to merge 1 commit into
Open
fix(filesystem): reject existing move destinations#4531dev-willbird1936 wants to merge 1 commit into
dev-willbird1936 wants to merge 1 commit into
Conversation
dev-willbird1936
force-pushed
the
fix/filesystem-move-no-overwrite
branch
from
July 23, 2026 14:34
282c88c to
fa89d69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the filesystem server's
move_filehonor its documented no-overwrite contract. Existing destination files, directories, and symlinks now return a tool error, including when another process creates the destination during the move.Server Details
move_fileMotivation and Context
POSIX
rename()can replace an existing destination. A separate existence check followed byrename()still has a check-to-use race, so a concurrent destination could be overwritten. The implementation now copies with exclusive destination creation and removes the source only after the copy succeeds.How Has This Been Tested?
structured-content.test.tssuite: 13 passed.git diff --check: passed.Breaking Changes
None to the documented API. A successful move now uses copy-then-remove rather than an atomic same-filesystem rename so that portable Node.js code can enforce no replacement. If copying fails, the source is retained.
Types of changes
Checklist
Additional context
fs.cp()is called withforce: falseanderrorOnExist: true, which makes destination creation exclusive and closes the overwrite race. Directory success and rejection without tree merging are covered by regression tests.