Add _meta to manifest schema and tests - #124
Merged
joan-anthropic merged 3 commits intoOct 10, 2025
Merged
Conversation
asklar
marked this pull request as ready for review
October 10, 2025 19:08
MarshallOfSound
previously approved these changes
Oct 10, 2025
MarshallOfSound
left a comment
MarshallOfSound
left a comment
Contributor
There was a problem hiding this comment.
Approving spec changes 👍
asklar
commented
Oct 10, 2025
Contributor
|
adding @domdomegg ! |
domdomegg
reviewed
Oct 10, 2025
domdomegg
reviewed
Oct 10, 2025
domdomegg
left a comment
domdomegg
left a comment
Member
There was a problem hiding this comment.
My overall opinion (am not the owner of mcpb stuff :), just 2 cents):
- I like the idea of
client_extensions. Giving the community an extension point that can be used flexibly seems like a good escape hatch + a way to learn how people are using things and adopt the good stuff. To align with the main MCP spec I might call this_meta, which can still have whatever you want in it basically. There's a bit of a convention of using reverse DNS names, e.g.com.microsoft.windowsmaybe, but it is freeform. - I'm not super convinced by
static_responsesyet. My guess is the performance benefit is pretty minimal, and it might duplicate a lot of the stuff already intoolsorprompts. For richer discovery it feels like it might live better in the registry (we've had some discussions there - see modelcontextprotocol/registry#79 and modelcontextprotocol/registry#82)
asklar
changed the title
joan-anthropic
approved these changes
Oct 10, 2025
…sions with _meta for improved organization
asklar
force-pushed
the
user/asklar/static_responses_and_extensions
branch
from
October 10, 2025 23:43
50a8c5a to
443d849
Compare
bryan-anthropic
pushed a commit
to bryan-anthropic/mcpb
that referenced
this pull request
Oct 28, 2025
…tatic_responses_and_extensions Add _meta to manifest schema and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
_metafield to the manifest for platform/client–specific metadata objects (e.g. Windowspackage_family_name, macOS bundle identifiers, custom client integration info).Schema, tests, and documentation updated accordingly.