Pin HuggingFaceDataset and HarborDataset to specific versions - #529
Open
anli5005 wants to merge 11 commits into
Open
Pin HuggingFaceDataset and HarborDataset to specific versions#529anli5005 wants to merge 11 commits into
anli5005 wants to merge 11 commits into
Conversation
Merged
|
Documentation preview: https://modal-labs-training-gym--training-gym-previews-preview-r-78da35.modal.run/529/docs |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This reverts commit 9a33623.
anli5005
marked this pull request as draft
September 10, 2026 15:50
anli5005
marked this pull request as ready for review
September 10, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #483, Devin pointed out that Hugging Face datasets remain cached even if a new revision is pushed. This PR fixes that pinning all
HuggingFaceDatasetinstances to a specifichf_revisiontag and taking it into account during caching. If nohf_revisionis passed, the initializer will automatically fetch the latest commit hash.This PR also pins
HarborDatasetinstances by default; if no version is specified in thedataset_name,HarborDatasetwill use the CLI to fetch the latest hash of the dataset and pin itself to that.This will give users finer-grained control over the lifetime of their Hugging Face datasets. Accordingly, support for
HuggingFaceDataset.always_download(formerlyalways_prepare) has been removed fromHuggingFaceDataset, as the default behavior will now just repeatedly re-download the same dataset revision. I keptHarborDataset.always_fetcharound for now to support path-based datasets.