Skip to content

Fix the previews app image build so it deploys again - #495

Draft
joyliu-q wants to merge 1 commit into
mainfrom
devin/1788376356-fix-previews-app-image
Draft

Fix the previews app image build so it deploys again#495
joyliu-q wants to merge 1 commit into
mainfrom
devin/1788376356-fix-previews-app-image

Conversation

@joyliu-q

@joyliu-q joyliu-q commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Deploys of training-gym-previews have been failing since the nginx conf dir moved into the image, so the deployed deploy_preview() predates #491 and dashboard previews still proxy /api at the deployed dashboard instead of the PR's own backend (visible on #489's preview job: Previews app does not accept api_url yet ...; deploying without it).

Modal rejects a build step that runs after a non-copy add_local_*:

An image tried to run a build step after using `image.add_local_*` to include local files.

Two chains did that; both now add the mounted (non-copy) file last:

  • module image: add_local_dir(nginx)add_local_file(astro_redirects, copy=True) becomes add_local_file(..., copy=True)add_local_dir(nginx)
  • docs sandbox image: add_local_file(docs.conf)add_local_file(astro-refresh.inc, copy=True) becomes the copy=True .inc first, then docs.conf

No behavioral change — same files land at the same paths. Not verifiable locally (hydrating an image needs Modal credentials this box doesn't have); the Previews App deploy on merge is the check.

Checklist

  • Example is documented with comments throughout, in a Literate Programming style.
  • Example does not require third-party dependencies to be installed locally
  • Example pins its dependencies
    • Example pins container images to a stable tag, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least minor version, ~=x.y.z or ==x.y
    • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

Link to Devin session: https://modal.devinenterprise.com/sessions/95e5ad2ac22742e98d76804b1c04343b
Open in Devin Desktop: https://modal.devinenterprise.com/desktop/session/95e5ad2ac22742e98d76804b1c04343b?variant=devin
Requested by: @joyliu-q

@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant