Fix the previews app image build so it deploys again - #495
Draft
joyliu-q wants to merge 1 commit into
Draft
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploys of
training-gym-previewshave been failing since the nginx conf dir moved into the image, so the deployeddeploy_preview()predates #491 and dashboard previews still proxy/apiat the deployed dashboard instead of the PR's own backend (visible on #489's preview job:Previews app does not accept api_url yet ...; deploying without it).Modal rejects a build step that runs after a non-
copyadd_local_*:Two chains did that; both now add the mounted (non-
copy) file last:add_local_dir(nginx)→add_local_file(astro_redirects, copy=True)becomesadd_local_file(..., copy=True)→add_local_dir(nginx)add_local_file(docs.conf)→add_local_file(astro-refresh.inc, copy=True)becomes thecopy=True.incfirst, thendocs.confNo behavioral change — same files land at the same paths. Not verifiable locally (hydrating an image needs Modal credentials this box doesn't have); the
Previews Appdeploy on merge is the check.Checklist
latestpython_versionfor the base image, if it is used~=x.y.zor==x.yversion < 1are pinned to patch version,==0.y.zLink to Devin session: https://modal.devinenterprise.com/sessions/95e5ad2ac22742e98d76804b1c04343b
Open in Devin Desktop: https://modal.devinenterprise.com/desktop/session/95e5ad2ac22742e98d76804b1c04343b?variant=devin
Requested by: @joyliu-q