Build slime and Miles base images from Modal named Images by default - #386
Draft
joyliu-q wants to merge 1 commit into
Draft
Build slime and Miles base images from Modal named Images by default#386joyliu-q wants to merge 1 commit into
joyliu-q wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Documentation preview: https://modal-labs-training-gym--training-gym-previews-preview-r-78da35.modal.run/386/docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor to #381: instead of an opt-in
named_imagerecipe arg, the launchers now resolve their base image viaImage.from_name(...)unconditionally.run_commands, so behavior is otherwise unchanged — only the base resolution changes from a registry pull to a named-Image lookup.SLIME_REGISTRY_IMAGEand used byscripts/publish_framework_images.py, which builds each registry image once and publishes it under the named ref (slimerl/slime:nightly-dev-20260722a,radixark/miles:dev-202608051303). Names with/publish under an environment prefix (slimerl,radixark), which must exist.scripts/fetch_slime_patch_snapshots.pykeeps reading from the registry digest.Deployment note: the names must be published once (
uv run scripts/publish_framework_images.py) before launches resolve them —from_namefails until then. Bumping to a newer upstream tag (e.g.slimerl/slime:nightly-dev-20260804a) is a constant change plus a republish.Checklist
N/A — library change, not an example. Ran
ruff check,ruff format,compileall, pre-commit, and the recipe/CLI test subset (230 passed).Link to Devin session: https://modal.devinenterprise.com/sessions/ecdc4eabe1a0494bba278a0a786d7d87
Requested by: @joyliu-q