Migrate control plane to Function @modal.asgi_app - #7
Merged
Conversation
Servers reject zero-to-one traffic with 503; Function asgi_app queues inputs so GitHub workflow_job webhooks survive cold starts. Drop RunnerServer/uvicorn, rename api to webhook, and accept form-urlencoded payloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunnerServer+ uvicorn) with a Runner-registered Function@modal.asgi_app+@modal.concurrentso cold-start webhooks queue instead of 503.api.py→webhook.py; keepWebhookApp/DeliveryStoreas internal collaborators. Metaserver_name→webhook_function. URL host is*.modal.run.add_local_python_source("runner_modal")until public package pin. Accept GitHub form-urlencodedpayload=bodies.release.ymlruns on self-hosted Modal labels.Test plan
self-hosted/modal/ci) via webhook — no manual dispatchty/ ruff / pytest green on the PRGET {Runner.from_name("ci").url}/healthreturns labels + concurrency*.modal.run/github