Skip to content

Harden webhook control plane and clarify naming - #2

Merged
botirkhaltaev merged 2 commits into
mainfrom
harden/webhook-control-plane
Jul 22, 2026
Merged

Harden webhook control plane and clarify naming#2
botirkhaltaev merged 2 commits into
mainfrom
harden/webhook-control-plane

Conversation

@botirkhaltaev

@botirkhaltaev botirkhaltaev commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Harden the webhook path: label admission, cancel → terminate named job, claim durability with lazy pending reclaim, and slim Runner job defaults (region, idle_timeout, experimental_options, runner_group_id).
  • Rename away from App / underscore “privacy” smells (WebhookApp, DeliveryStore, KIND_TAG / JOB_KIND, …) and add a Naming section to AGENTS.md.
  • Document soft /cache Volume vs actions/cache; example sets idle_timeout=900.

Test plan

  • Unit tests: admission → 204, cancel → terminate, stale pending reclaim, no release after successful create
  • Redeploy acme-ci and confirm webhook still accepts pool-labeled jobs
  • Cancel a running job and confirm the Modal Sandbox terminates
  • Confirm CI (ruff / ty / pytest) passes on self-hosted Modal runners

Botir Khaltaev and others added 2 commits July 22, 2026 14:55
Add label admission, cancel terminate, claim durability, and slim job
defaults; instrument runner _diag for live-log diagnosis; rename away
from App/underscore smells and document naming rules in AGENTS.md.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep live-log _diag tooling for local testing only; product path is plain run.sh.

Co-authored-by: Cursor <cursoragent@cursor.com>
@botirkhaltaev
botirkhaltaev merged commit 3ba193c into main Jul 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant