ci: drop pnpm version override - #7
Open
hulk510 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Pages deployment workflow for Storybook and the registry so pnpm is resolved from packageManager rather than an explicit action version.
Changes:
- Adds/configures a Pages workflow that checks out the repo, installs dependencies with pnpm, builds docs and registry assets, and deploys Storybook to GitHub Pages.
- Removes the explicit pnpm version input from
pnpm/action-setup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+35
| - run: pnpm --filter @mod-ui/registry build | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages workflow fails because pnpm/action-setup v4 sees both
version: 9in theaction input and
packageManager: pnpm@9.0.0in package.json. Remove theexplicit version so packageManager wins.