fix: skip unavailable devices during adb-server enumeration#107
Open
PointBreaker wants to merge 1 commit into
Open
fix: skip unavailable devices during adb-server enumeration#107PointBreaker wants to merge 1 commit into
PointBreaker wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
host:devicesincludes each transport's state, butlistDadbs()currently discards it and constructs aDadbfor every serial. Constructing anunauthorizedorofflinetransport throws during the feature query and aborts the whole list, hiding healthy devices on the same host.This was reproduced through Maestro with a healthy requested device remaining continuously available to adb while dadb-based discovery reported no connected Android devices.
Change
devicestate.IOExceptionfrom one entry so a transport race cannot hide the other healthy devices.AdbServerDadbinitialization and connection behavior unchanged.Testing
./gradlew :dadb:test --tests dadb.adbserver.AdbServerDeviceListTestFixes #55
Fixes #62
Related to #98 and mobile-dev-inc/Maestro#3456.