Repository navigation
Optional tabbed editor layout - #9
Closed
xbraindance wants to merge 1 commit into
Closed
xbraindance wants to merge 1 commit into
xbraindance wants to merge 1 commit into
Conversation
The full panel is 2338 px wide, which is hard to fit on smaller screens. System > Tabbed Layout shows the panel as three tabs (Oscillator, Filter, Control) beside a fixed screen section, with the transport row, System Volume and the System menu always visible. The choice is remembered beside the panel-skin preference. Each tab is a list of original-SVG rectangles translated into a smaller view, so artwork, hit regions, LEDs and firmware wiring are reused unchanged; the classic layout is the identity mapping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks for the contribution. I prefer to preserve the original artwork as a complete panel, and splitting it into smaller tabbed sections does not fit the UI direction for this project. The new compact UI option addresses the smaller-screen issues this PR aims to solve, so I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
mo0kid/wavemain (c7b0b53). UI only; no firmware, audio or state-format changes beyond one remembered preference.The full panel is 2338 px wide, which is hard to fit on smaller screens. System > Tabbed Layout shows the panel as three tabs (Oscillator, Filter, Control) beside a fixed screen section, with the transport row, System Volume and the System menu always visible. The choice is remembered beside the panel-skin preference. The default stays the classic layout.
Each tab is a list of original-SVG rectangles translated into a smaller view, so artwork, hit regions, LEDs and firmware wiring are reused unchanged; the classic layout is the identity mapping.
Rebased onto 0.1.12: its System menu items took ids 0x470e/0x470f, so the Tabbed Layout item moved to 0x4710. No other conflicts.
Verification
ctest: 4/4 (WaveCoreTests, M68000ThreadTests, WaveHostStateTests, WavePublicEditorTests); the editor test covers the layout toggle. I have not exercised each tab by hand on the 0.1.12 build, andWaveEditorTests(private assets) was not run.🤖 Generated with Claude Code