Harden runtime dependencies, diagnostics paths, and embedding retries#478
Harden runtime dependencies, diagnostics paths, and embedding retries#478raitoxlol wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Wright Williams seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Merged in 21ff279. @raitoxlol solid first contribution. Three fixes in one PR, each with focused tests.
|
What changed
PyYAML>=6.0as a runtime dependency and updateuv.lock.HERMES_HOMEwhen it is set.Why
Clean installs failed during first-run config initialization because the package imported
yamlwithout declaring PyYAML. Diagnostics ignoredHERMES_HOMEand could write into a different Hermes installation. Transient embedding endpoint failures returned immediately, creating silent embedding gaps.Validation
13 passedpython3 -m compileall: passedscripts/verify-docs.py: passed (website docs skipped because the sibling checkout is unavailable)python -m build: passedHERMES_HOME.The full test suite was not run here; one existing diagnostics test fails because the current implementation closes a database connection that the test later reuses.