Remove rotating dipoles capability from interactive dipole fitting GUI - #14243
Merged
Conversation
larsoner
approved these changes
Aug 28, 2026
larsoner
left a comment
larsoner
left a comment
Member
There was a problem hiding this comment.
Yes simplifications are nice!
larsoner
enabled auto-merge (squash)
August 28, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation was broken and I don't see a way to make it actually work. When computing the dipole timecourses with the MNE algorithm, either all dipoles are rotating (
loose=1.0) or fixed (loose=0). Having some fixed and some rotating seems challenging to actually get working.