Speed up label adjacency computation - #14229
Merged
Merged
Conversation
larsoner
enabled auto-merge (squash)
August 27, 2026 10:20
github-project-automation
Bot
moved this to Ideas
in 2026 MNE-Python Maintainers Sprint
github-project-automation
Bot
moved this from Ideas
to Done
in 2026 MNE-Python Maintainers Sprint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14226 -- I saw it using a large source space and went to change it to use
sampleplusoct3, then realized with Opus 5 (drafted changes, I reviewed and iterated) there were faster ways to compute the adjacency using sparse matrix tricks, plusdijkstrafrom scipy (less code for us to maintain!) 🚀This is about the same + as -, but a lot of the old code is just in comments so that the old / naive way can be viewed next to the faster one. (I find this is helpful when revisiting code later.)
I think we can trust our existing unit tests and verified equivalences here so I'll self-mark for merge-when-green.