Try removing all the _process_events calls and see what happens - #14227
Merged
Conversation
larsoner
disabled auto-merge
August 26, 2026 13:31
larsoner
enabled auto-merge (squash)
August 26, 2026 13:40
larsoner
disabled auto-merge
August 26, 2026 14:28
larsoner
enabled auto-merge (squash)
August 26, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually processing QT events inside an event handler wreaks havoc when having multiple event handlers attached to the same event. The first event handler "steals" all the events this way.
@larsoner and I were wondering whether these explicit calls to
_process_eventsare actually necessary.This PR removes a lot of them and adds unit tests to see if anything breaks.