XFit-style dipole fitting GUI - #13074
Merged
Merged
Conversation
ENH: Reapir and enahnce logic of ChannelsSelect event handling in Xfit-like dipole GUI
Member
|
@wmvanvliet I pushed some tests and some minor fixes. Good to go from your end? If so I say let's merge and keep iterating in follow-up PRs! Updated example here. |
wmvanvliet
marked this pull request as ready for review
August 26, 2026 14:42
larsoner
enabled auto-merge (squash)
August 26, 2026 15:00
natinew77-creator
added a commit
to natinew77-creator/mne-python
that referenced
this pull request
Aug 26, 2026
mne-toolsgh-13074 made mne/viz/_3d.py write channel names onto the second value instanced_mesh returns, which broke plot_alignment here three ways: a pyvista-js PolyData has no field_data, several colours came back as a list, and empty positions came back as None. Return the per-instance point cloud instead, always one object with the mapping attached, which is what _PyVistaRenderer returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a GUI to perform guided dipole modeling in the spirit of MEGIN's XFit program. This PR contains the base functionality needed to make the GUI useful. Useful enough to include in the next release of MNE-Python. The plan is to keep adding features in future PRs as well as some sorely needed speed improvements.
See here for a list of currently supported features: #11977
This PR depends on: #12071
Minimal example:
Todo: